Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Demo & docs] Minor corrections to CONTRIBUTING.md #1681

Merged
merged 4 commits into from
Mar 13, 2024

Conversation

oneolddev
Copy link
Contributor

Pull Request

πŸ“– Description

Corrections and additions to CONTRIBUTING.md.

🎫 Issues

  • requirement for NodeJS is not noted
  • there was still a reference to FAST-Blazor
  • error in cloning with SSH

πŸ‘©β€πŸ’» Reviewer Notes

πŸ“‘ Test Plan

βœ… Checklist

General

  • I have added tests for my changes.
  • I have tested my changes.
  • I have updated the project documentation to reflect my changes.
  • I have read the CONTRIBUTING documentation and followed the standards for this project.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has already been fixed

@vnbaaij vnbaaij merged commit 39ddcd5 into microsoft:dev Mar 13, 2024
2 checks passed
vnbaaij added a commit that referenced this pull request Mar 15, 2024
* Fix Wizard link (#1660)

* updates contributing.md file

---------

Co-authored-by: Vincent Baaij <[email protected]>
@oneolddev oneolddev deleted the patch-1 branch March 18, 2024 22:38
@vnbaaij vnbaaij changed the title Minor corrections to CONTRIBUTING.md [Demo & docs] Minor corrections to CONTRIBUTING.md Mar 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants